-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selfhosting #8
Selfhosting #8
Conversation
Thank you, this looks great. I'll look over it tomorrow and give you detailed feedback on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I added some notes to your code, please look over them and change the PR respectively.
Hi, thanks, I'll do everything on Monday. |
It's always easy way to delete some functionality, but not very easy to add it. For home use you can just push 1 value to whole database column (AspNetUsers->EmailConfirmed) all users will become verified. In my opinion - "delete unconfirmed users it's very good thing. I've created a dozen users while testing, and all of them were automatically deleted by server because of unconfirmed email. But i think it's up on you to decide. |
Hm, I get your point, but I don't think that its worth the extra struggle for the end user. I think by far most people who want to self-host Librum will simply setup one account and be happy with it. If they want an account deleted, they can simply delete it by logging into it and clicking "Delete Account" in the settings. Setting up an extra SMTP service to simply use Librum is a big burden imo. so keeping it as simple as possible would be good. Also, by not requiring the user to set up an SMTP service, we literally just require the user to copy paste a few lines (which we provide in the documentation) and it will just work. |
I Never can argue with "Keep it simple" ! ) |
From what I see the server only sends emails in two places: When registering and when resetting the password. I have already removed the email sending while registering. I'll now look into the password resetting. |
The only option to avoid the email sending in the password reset is to open a browser with the form right from the server, but this is not a very nice way to handle this. |
I believe that a user who can install and configure the database and server service in linux will not be confused by the mail setup, its basics, no rocket since. IMHO, the program is primarily interesting for the possibility of launching a full-fledged server. If we disable sending email when password reset, we can same way disable password, i think. May be email confirmation for register is not necessary , but for password reset you need email or sms, it's basic way to keep data private. |
You are right, I did not think about the fact that not sending an email to the account's owner on a password reset would basically make passwords useless and thus destroy all of the security. I will revert the last commit I made and we will keep the email sending for self-hosted servers. |
0186856
to
41faf3f
Compare
Ok, it is running just fine together with the client application. |
It seems like mariadb didn't like it that updating highlights just overwrites all of them with the new ones thus it threw an error. I have now added proper updating of highlights.
Ok, everything looks good so far. Have you tested if password resetting works fine for the self-hosted server? I don't have a self-hosted email, thus I can not test it. Can you confirm that it works fine? |
It looks like you're putting things in order today. good job! |
You can test it with any public email service like gmail, aol, etc. I' ve made some tests, it works fine with my email server. |
I mean you don't need a self-hosted email server. You can use any public email, if it allows smtp mail client usage. |
Yes, pretty much everything should be done now. Could you change the PR request to merge into dev/develop instead of main though? |
Done. |
IF LIBRUM_SELFHOSTED != true - nothing will be changed.
IF LIBRUM_SELFHOSTED == true
PS.
BookRepository.cs string to Double parsing method was changed due problems with running on linux (it was throwing exception)
I would like you to take a look, I'm pretty shure we can work it out to run perfect!
For now we can run this server as linux service in fully self-hosted mode using install instruction from my fork.
At the same time azure services will continue their normal work if not self-hosted.